Skip to content

Conversation

@briankalwat
Copy link

DESCRIPTION

What does this PR do, or why is it needed?

In case you are submitting a non bug-fix-PR, we highly recommend you to engage in a PR discussion first.

There are many factors we consider before accepting a pull request. This includes:

  1. Whether or not the Rock system you run is a standard, main-line build. If it is not, there is a lower chance we will accept your request since it may impact some other part of the system you don't regularly use.
  2. Features that would be used by less than 80% of Rock organizations, or ones that don't match the goals of Rock.

With the PR discussion we can assess your proposed changes before you start working on it so that we can come up with the best possible approach to it. This may include:

  1. Coming up with an alternate approach that does not involve changes to core.
  2. Advising how your proposed solution be done in a different way that is more efficient and consistent with the rest of the system.
  3. Have one of our core developers make the changes for you. This may be the case if the change involves intricate tasks like an EF migration or something similar.

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • Testing info includes any items that need to be added to a local Rock instance in order to test and/or the database against which it can be tested.
  • Upload GIF(s) of relevant changes
  • Set a relevant reviewer

Please include screenshots if your pull request either alters existing UI or provides new UI. Arrows and labels are helpful.
-->

  • Review code through the lens of being concise, simple, and well-documented
  • Manual QA to ensure the changes look/behave as expected

The purpose of PR Review is to improve the quality of the software.

briankalwat and others added 30 commits September 27, 2021 11:26
Updated card list to use linkurl property first when linking an item card, if a value exists
Updated datasets by channel layout
Updated card list to use linkurl property first when linking an item card, if a value exists
Pre-Alpha 13.0.23 > Master
Fixed issue where a Workflow with a Workflow Entry Form could produce duplicate workflows
Workflows Cherry-Pick > Beta
Workflows Cherry-Pick > Master
Fixed an issue with date filters not correctly parsing DST dates for some timezones
Fixed an issue with date filters not correctly parsing DST dates for some timezones.
Pre-Alpha Release 13.0.27 > Alpha
…ge-updates

Merging alpha into homepage-updates with changes from prealpha 13.0.27
ns-brandonwilson and others added 28 commits July 20, 2023 16:08
…-update

Added BackgroundImageSquare attribute to Content Channel Items by Cha…
…pha-sync

Merged alpha into the pre-alpha-sync branch
- pulling changes from alpha into fluid branch
…pha-sync

- pulling alpha over pre-alpha-sync
…to become unstable when aggregating capacity metrics for group types that reference themselves in a parent, child relationship.
Live Metrics Cherry-Pick > Alpha
- pulled in alpha on top of fluid changes
Fluid Theme Changes > Alpha
More lava updates for fluid > Alpha
@briankalwat briankalwat changed the title Articles Updates Lava Shortcode Updates, Followings Script Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.